Merged
Conversation
Kobzol
reviewed
Jan 29, 2026
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
It certainly looks like an improvement! I wonder if you'll feel the urge to refactor it further after my talk 😆
| assert_eq!(r.n_enabled_variants(), 0); | ||
|
|
||
| let task = TaskBuilder::new(task_id) | ||
| let task = TaskBuilder::new() |
Member
There was a problem hiding this comment.
It would be better if there was some test context from which you create the task builder, and it assigns the task id automatically, rather than choosing the ID manually in tests :)
Collaborator
Author
There was a problem hiding this comment.
I plan this but in the next iteration during integrating of scheduler-v2, because lots of current scheduler tests will be written differently.
| submit_test_tasks(&mut core, vec![a, b, c, d, e]); | ||
|
|
||
| let mut rt = TestEnv::new(); | ||
| let a = rt.new_task_default(0); |
Member
There was a problem hiding this comment.
😆 I feel like you were reading my slides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring of Tako tests.