Skip to content

Commit 0d6faeb

Browse files
committed
corrected source files regarding checkstyle errors
1 parent c7a8601 commit 0d6faeb

File tree

3 files changed

+14
-13
lines changed

3 files changed

+14
-13
lines changed

pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -388,6 +388,7 @@
388388
<module name="ConstantName" />
389389
<module name="EmptyStatement" />
390390
<module name="NeedBraces" />
391+
<module name="UnnecessaryParentheses" />
391392
</module>
392393
</module>
393394
</checkstyleRules>

src/test/java/net/sf/jsqlparser/test/select/SelectTest.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -413,32 +413,32 @@ public void testLimit4() throws JSQLParserException {
413413
select = (Select) parserManager.parse(new StringReader(statement));
414414
offset = ((PlainSelect) select.getSelectBody()).getLimit().getOffset();
415415
rowCount = ((PlainSelect) select.getSelectBody()).getLimit().getRowCount();
416-
assertEquals("name2", (((JdbcNamedParameter) rowCount).getName()));
416+
assertEquals("name2", ((JdbcNamedParameter) rowCount).getName());
417417
assertEquals("name1", ((JdbcNamedParameter) offset).getName());
418418
assertFalse(((PlainSelect) select.getSelectBody()).getLimit().isLimitAll());
419419

420420
statement = "SELECT * FROM mytable WHERE mytable.col = 9 LIMIT ?1, :name1";
421421
select = (Select) parserManager.parse(new StringReader(statement));
422422
offset = ((PlainSelect) select.getSelectBody()).getLimit().getOffset();
423423
rowCount = ((PlainSelect) select.getSelectBody()).getLimit().getRowCount();
424-
assertEquals(1, (int) (((JdbcParameter) offset).getIndex()));
425-
assertEquals("name1", (((JdbcNamedParameter) rowCount).getName()));
424+
assertEquals(1, (int) ((JdbcParameter) offset).getIndex());
425+
assertEquals("name1", ((JdbcNamedParameter) rowCount).getName());
426426
assertFalse(((PlainSelect) select.getSelectBody()).getLimit().isLimitAll());
427427

428428
statement = "SELECT * FROM mytable WHERE mytable.col = 9 LIMIT :name1, ?1";
429429
select = (Select) parserManager.parse(new StringReader(statement));
430430
offset = ((PlainSelect) select.getSelectBody()).getLimit().getOffset();
431431
rowCount = ((PlainSelect) select.getSelectBody()).getLimit().getRowCount();
432-
assertEquals(1, (int) (((JdbcParameter) rowCount).getIndex()));
433-
assertEquals("name1", (((JdbcNamedParameter) offset).getName()));
432+
assertEquals(1, (int) ((JdbcParameter) rowCount).getIndex());
433+
assertEquals("name1", ((JdbcNamedParameter) offset).getName());
434434
assertFalse(((PlainSelect) select.getSelectBody()).getLimit().isLimitAll());
435435

436436
statement = "SELECT * FROM mytable WHERE mytable.col = 9 LIMIT :param_name";
437437
select = (Select) parserManager.parse(new StringReader(statement));
438438
offset = ((PlainSelect) select.getSelectBody()).getLimit().getOffset();
439439
rowCount = ((PlainSelect) select.getSelectBody()).getLimit().getRowCount();
440440
assertNull(offset);
441-
assertEquals("param_name", (((JdbcNamedParameter) rowCount).getName()));
441+
assertEquals("param_name", ((JdbcNamedParameter) rowCount).getName());
442442
assertFalse(((PlainSelect) select.getSelectBody()).getLimit().isLimitAll());
443443
}
444444

@@ -753,8 +753,8 @@ public void testUnion() throws JSQLParserException {
753753
getName());
754754
assertEquals("mytable2", ((Table) ((PlainSelect) setList.getSelects().get(2)).getFromItem()).
755755
getName());
756-
assertEquals(3, (((LongValue) (((PlainSelect) setList.getSelects().get(2)).getLimit().
757-
getOffset())).getValue()));
756+
assertEquals(3, ((LongValue) ((PlainSelect) setList.getSelects().get(2)).getLimit().
757+
getOffset()).getValue());
758758

759759
// use brakets for toString
760760
// use standard limit syntax
@@ -777,9 +777,9 @@ public void testUnion2() throws JSQLParserException {
777777
getName());
778778
assertEquals("mytable2", ((Table) ((PlainSelect) setList.getSelects().get(2)).getFromItem()).
779779
getName());
780-
assertEquals(3, (((LongValue) (((PlainSelect) setList.getSelects().get(2)).getLimit().
781-
getRowCount())).getValue()));
782-
assertNull((((PlainSelect) setList.getSelects().get(2)).getLimit().getOffset()));
780+
assertEquals(3, ((LongValue) ((PlainSelect) setList.getSelects().get(2)).getLimit().
781+
getRowCount()).getValue());
782+
assertNull(((PlainSelect) setList.getSelects().get(2)).getLimit().getOffset());
783783
assertEquals(4, ((PlainSelect) setList.getSelects().get(2)).getOffset().getOffset());
784784

785785
// use brakets for toString

src/test/java/net/sf/jsqlparser/test/simpleparsing/CCJSqlParserManagerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ public static String getLine(BufferedReader in) throws Exception {
6060
while (true) {
6161
line = in.readLine();
6262
if (line != null) {
63-
if (((line.length() < 2) || (line.length() >= 2) && !(line.charAt(0) == '/' && line.
64-
charAt(1) == '/'))) {
63+
if ((line.length() < 2) || (line.length() >= 2) && !(line.charAt(0) == '/' && line.
64+
charAt(1) == '/')) {
6565
break;
6666
}
6767
} else {

0 commit comments

Comments
 (0)