Open
Conversation
Owner
|
Hey. Thanks for this. I must admit i'm at a slight crossroads about including this. I had thought about doing it myself, but my concern is that once you start renaming properties to Ideally the world will move on to OpenAPI 3.1.X which allows for JSON schemas greater than Draft-04 and there won't be a need for this library. Will have a think, but thank you for the PR and please don't be dissuaded from adding anymore additions or improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for #17.
Mimicked the behaviour of what's done here to convert the
patternPropertiesobject intox-patternProperties.Given it's only using the Specification Extension functionality of adding
^x-on the front of the unsupported property, it's not supported by a lot of tools, but it abides by the specification at least?I haven't been able to contribute much to Open Source before, so I hope this is helpful!