fix(core): use synchronous asset loading for AOT metadata#630
Merged
JasonXuDeveloper merged 2 commits intomasterfrom Feb 13, 2026
Merged
fix(core): use synchronous asset loading for AOT metadata#630JasonXuDeveloper merged 2 commits intomasterfrom
JasonXuDeveloper merged 2 commits intomasterfrom
Conversation
LoadMetadataForAOTAssemblies used LoadAssetAsync + await per file, causing N+ frames of unnecessary delay during initialization. Since this runs before gameplay, synchronous loading is safe and eliminates the frame-per-file overhead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
There was a problem hiding this comment.
Pull request overview
This PR optimizes the AOT metadata loading process by replacing asynchronous asset loading with synchronous loading, eliminating unnecessary frame delays during bootstrap initialization. The change converts LoadMetadataForAOTAssemblies from an async UniTask method to a void method, using LoadAssetSync instead of LoadAssetAsync + await.
Changes:
- Replaced
YooAssets.LoadAssetAsyncwithYooAssets.LoadAssetSyncfor AOT metadata list loading - Replaced
YooAssets.LoadAssetAsyncwithYooAssets.LoadAssetSyncfor individual AOT DLL loading - Changed method signature from
async UniTask LoadMetadataForAOTAssemblies()tovoid LoadMetadataForAOTAssemblies() - Updated caller to invoke the method synchronously (removed
await)
UnityProject/Packages/com.jasonxudeveloper.jengine.core/Runtime/Bootstrap.cs
Show resolved
Hide resolved
UnityProject/Packages/com.jasonxudeveloper.jengine.core/Runtime/Bootstrap.cs
Show resolved
Hide resolved
Validate handle.Status before accessing asset objects to prevent null reference exceptions when sync loads fail. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoadAssetAsync+awaitwithLoadAssetSyncinLoadMetadataForAOTAssemblies, eliminating N+ frames of unnecessary delay during initializationasync UniTasktovoidsince no async operations remainTest plan
🤖 Generated with Claude Code