allow [$:] as prefix and plain ? for prepared statements#15
Open
oger000 wants to merge 1 commit intoJavaScriptor:masterfrom
oger000:pr/prepared-statement
Open
allow [$:] as prefix and plain ? for prepared statements#15oger000 wants to merge 1 commit intoJavaScriptor:masterfrom oger000:pr/prepared-statement
oger000 wants to merge 1 commit intoJavaScriptor:masterfrom
oger000:pr/prepared-statement
Conversation
Member
|
hi @oger000 , thanks for the pr and sorry for the late reply. There are two things need to be discussed:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows handling of the $-prefix (postgresql and sequelize bind), :-previx (PHP PDO and sequelize replace) and single ? (most DBS for prepared steatement.
But this PR allows this placeholder on more positions than the underlaying databases, so its for people who need preapared-statement support and know what they do. I am not shure if this should go into master. Anyway it works for me and is out for now.
By the way some trailing whitespace are stripped, so use git diff -w