-
Notifications
You must be signed in to change notification settings - Fork 6
feat: emergency checklist — allow Remote Coordinators to mark tasks complete; admin checklist/subtask management & reporting #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kathirpsmy
wants to merge
13
commits into
JonathanGarro:main
Choose a base branch
from
kathirpsmy:feature/127-assignment-checklist
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added feature to show checklist in the Emergency page. Added Admin section to manage Checklist and Emergency Cheklist.
- Introduced SubTask and AssignmentSubTask models to handle sub-tasks associated with checklists. - Updated forms to include fields for sub-task creation and editing. - Enhanced routes to support adding, editing, and removing sub-tasks. - Modified checklist management templates to display and manage sub-tasks. - Implemented emergency checklist assignment with sub-tasks. - Created new templates for editing checklists and sub-tasks. - Added migration script to create sub-task related tables in the database.
…ates and task report tab
…nality - Cleaned up whitespace and formatting for better code clarity. - Enhanced the emergency checklist section with improved structure and comments. - Added functionality for overriding completion dates with a modal. - Implemented JavaScript to handle checkbox interactions and form submissions. - Removed redundant task status table to streamline the interface.
- Updated the AssignmentSubTask model to include a `task_completed_by` field to track which user completed a task. - Modified the update_task_status route to set the `task_completed_by` field when a task is marked as completed. - Enhanced the admin_manage_checklist template to display the user who completed a task. - Added a new route to fetch user information by ID for displaying the name of the user who completed the task. - Created a migration script to add the `task_completed_by` column to the assignment_sub_task table and establish the foreign key relationship with the user table.
…leted by information
… subtask completion information
…s with robust parsing and retention logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emergency checklist — Remote Coordinator task completion, admin checklist/subtask management, and reporting
This pull request introduces the Emergency Checklist feature improvements and admin management tools. It enables SIMS Remote Coordinators (RCs) to mark tasks and subtasks as completed for their assignments, tracks who completed items and when, improves subtask ordering and error handling, and adds admin UI/endpoints to manage checklists, subtasks and report options. It also enhances reporting by adding detailed emergency task statistics and subtask completion data.
Highlights
Why this change
Remote Coordinators need to record when they complete tasks against assignments. Admins needed better tools to manage and maintain checklists and subtasks and prevent accidental data loss. The new reporting makes it easy to audit task completion across emergencies.
Files and areas changed (high level)
Commit list from this branch (chronological newest -> oldest)
Database migration notes
This branch contains Flask-Migrate (Alembic) migration scripts. Before you deploy or run the app locally after pulling this branch, apply the migrations to update your database schema.
Recommended local dev steps (PowerShell)
flask_app/requirements.txtlives):Notes and safety tips
flask_app/migrations/versions/to see the exact schema changes.FLASK_APPaccordingly (e.g.SIMS_Portal:create_app()if applicable).Docker / container instructions
If you run the app inside Docker (docker-compose), after building/updating the image you can run the upgrade inside the running container:
If your container doesn't have the Flask CLI available, run the upgrade using the python entrypoint and Flask-Migrate scripts (for example
python -m flask db upgradeinside the container).Testing and validation
flask db upgrade, run a quick smoke test: create a test assignment and mark a subtask complete via the UI or API. Confirm the completed_by and completion timestamp fields are present and saved.resolves #127