Move StaticArrayStyle here.#8
Conversation
StaticArrayStyle here.
Codecov Report
@@ Coverage Diff @@
## main #8 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 46 48 +2
=========================================
+ Hits 46 48 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looks fine, could you just add a test for the constructor and bump version? I haven't merged #5 yet because I don't know which methods of |
Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
I'm assuming But if some package want to add more methods, I think we will have to move |
Technically
That is very likely but it should not be a problem. |
|
@N5N3 could you make a corresponding PR to StaticArrays.jl? |
|
Is it ok to wait for similar_type?
There seems no need to separate their movement, as no other guys said they also want to move StaticArrayStyle here.
…------------------ Original ------------------
From: Mateusz Baran ***@***.***>
Date: Tue,Aug 23,2022 6:41 PM
To: JuliaArrays/StaticArraysCore.jl ***@***.***>
Cc: N5N3 ***@***.***>, Mention ***@***.***>
Subject: Re: [JuliaArrays/StaticArraysCore.jl] Move `StaticArrayStyle` here. (PR #8)
@N5N3 could you make a corresponding PR to StaticArrays.jl?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
I wouldn't like to have StaticArraysCore and StaticArrays desynchronized for too long. Are you planning to work on similar_type this week? Or do you just need the function definition like in #5 ? |
|
StructArrays.jl only wants to call similar_type, so #5 is enough for us.
…------------------ Original ------------------
From: Mateusz Baran ***@***.***>
Date: Tue,Aug 23,2022 7:03 PM
To: JuliaArrays/StaticArraysCore.jl ***@***.***>
Cc: N5N3 ***@***.***>, Mention ***@***.***>
Subject: Re: [JuliaArrays/StaticArraysCore.jl] Move `StaticArrayStyle` here. (PR #8)
I wouldn't like to have StaticArraysCore and StaticArrays desynchronized for too long. Are you planning to work on similar_type this week? Or do you just need the function definition like in #5 ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
OK, then I will finish that PR today. |
) * Define `similar_type` and `StaticArrayStyle` in core package. See JuliaArrays/StaticArraysCore.jl#5 and JuliaArrays/StaticArraysCore.jl#8 * Bump version * Update Project.toml Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com> Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
This PR wants to move
,SizeStaticArrayStyle,, andis_staticarray_like(renamed fromisstatic)into Core package.similar_typeThese functions are needed in
StructArrays.jlto support static broadcast for aStructArrayofStaticArrays. JuliaArrays/StructArrays.jl#215 (comment)Edit: It turns out we only need
StaticArrayStyleandsimilar_typeto achieve this. Sincesimilar_typehas been taken care by #5This PR only wants to move
StaticArrayStylehere.