don't force eager conversions when not necessary, fix #228#229
don't force eager conversions when not necessary, fix #228#229aplavin wants to merge 1 commit intoJuliaArrays:masterfrom
Conversation
|
Seems reasonable to me. For tuples and named tuples the conversion would happen field by field regardless when calling EDIT: thinking more about it, this has issues for nested structures. For example, the following errors here but works on master julia> using StructArrays
julia> s = StructArray(x=StructArray(rand(ComplexF64, 1)))
1-element StructArray(StructArray(::Vector{Float64}, ::Vector{Float64})) with eltype NamedTuple{(:x,), Tuple{ComplexF64}}:
(x = 0.1722611417806078 + 0.4879486345600308im,)
julia> push!(s, (x=1,))
ERROR: type Int64 has no field reThe reason is that |
|
Personally, I would close this unless #228 gets a better example of a real problem. |
No description provided.