Skip to content

Highlight the correct bins in histograms #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vchuravy merged 1 commit into from
Jul 9, 2021
Merged

Highlight the correct bins in histograms #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/trials.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,11 +422,11 @@ function Base.show(io::IO, ::MIME"text/plain", t::Trial)
# Histogram

histquantile = 0.99
# The height and width of the printed histogram in characters.
histheight = 2
histwidth = 42 + lmaxtimewidth + rmaxtimewidth

histtimes = t.times[1:round(Int, histquantile*end)]
# 47 = the 'base' width such that the histogram doesn't go past the statistics text
bins, logbins = bindata(histtimes, histwidth - 1), false
append!(bins, [1, floor((1-histquantile) * length(t.times))])
# if median size of (bins with >10% average data/bin) is less than 5% of max bin size, log the bin sizes
Expand All @@ -438,8 +438,8 @@ function Base.show(io::IO, ::MIME"text/plain", t::Trial)
maxbin = maximum(bins)

delta1 = (histtimes[end] - histtimes[1]) / (histwidth - 1)
medpos = 1 + round(Int, (histtimes[length(histtimes) ÷ 2] - histtimes[1]) / delta1)
avgpos = 1 + round(Int, (mean(histtimes) - histtimes[1]) / delta1)
medpos = 1 + round(Int, (histtimes[length(t.times) ÷ 2] - histtimes[1]) / delta1)
avgpos = 1 + round(Int, (mean(t.times) - histtimes[1]) / delta1)

print(io, "\n")
for histrow in eachrow(hist)
Expand Down