Pass keyword arguments to test_approx when checking thunks#247
Pass keyword arguments to test_approx when checking thunks#247
test_approx when checking thunks#247Conversation
test_approx when checking chunkstest_approx when checking thunks
These test errors all seem to happen in checks that involve thunks. So I assume these tests were a bit brittle before but passed (usually) with the default |
|
A second observation is that the failing tests involve comparisons of Edit: And the test is stochastic on purpose it seems. |
|
Test errors should be fixed now. If there are no additional comments, I'll merge when the CR downstream tests pass. |
Right the stocasticity isn't on purpose, we just need to trick type inference into failing. |
Just ran into a test issue where I need
nans=trueas keyword argument toisapprox(cf #220) but it was not forwarded when testing pullbacks with chunks.