Fix step size calculation if some results are non-deterministic (inf …#245
Merged
oxinabox merged 6 commits intoJuliaDiff:mainfrom Sep 13, 2025
Merged
Fix step size calculation if some results are non-deterministic (inf …#245oxinabox merged 6 commits intoJuliaDiff:mainfrom
oxinabox merged 6 commits intoJuliaDiff:mainfrom
Conversation
oscardssmith
requested changes
Sep 12, 2025
giordano
reviewed
Sep 12, 2025
Contributor
Author
|
relatedly @oscardssmith can we add EnzymeTestUtils as reverse CI here too [as I see ChainRulesTestUtils as such a a reverse CI] |
Member
|
I would defer on CI decisions to someone more deeply involved in this package. |
oscardssmith
approved these changes
Sep 12, 2025
Contributor
Author
|
fair and yeah can follow up later on that. ci chainrules error is unrelated |
Member
oxinabox
approved these changes
Sep 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…derivative) or nan
step size is calculated based of the initial derivatives of all results. However, if some of the results return nan and/or are non-determinstic, the step size will be inf/nan, causing all other results to be broken -- instead of just the result which is expected to have an inf/nan derivative
cc @vchuravy @giordano