Fix deploydocs call in make.jl#7
Conversation
Generation of documentation was skipped because the optional field `devbranch` was set to "main" instead of "master". Deleting this keyword argument instructs Documenter.jl to figure out the correct branch name automatically.
|
@hakkelt I set the repo configs to deploy the pages from the |
|
Oh now I do, all good |
|
Thanks! Could you release version 0.2.0? |
|
@hakkelt the bump from 0.1.2 -> 0.2.0 is regarded as breaking. Is there actually anything breaking here? If not, we should probably name the release 0.1.3 (this came up since the registration needs release notes for merging) |
|
Well, I don't think the changes are breaking in themselves, at not least technically, and I'm not strongly against v0.1.3. What I see why incrementing to v0.2.0 would be more clean because it would prevent the current ProximalOperators version (v0.16.1) that still have the moved functions to use this ProximalCore version. Although ProximalOperators v0.16.1 and the new ProximalCore version would most likely work together despite the duplicated functions, it might lead to confusion. My suggestion is to bump ProximalCore to v0.2.0, but change the version of ProximalOperators in a non-breaking way. ProximalCore is currently unlikely to be used by anyone other than ProximalOperators and ProximalAlgorithms (at least, there is no other registered package that depends on it: https://juliapackages.com/p/proximalcore), so we are basically free to choose a version number. |
|
Makes sense, v0.2.0 is registered! |
Generation of documentation was skipped because the optional field
devbranchwas set to "main" instead of "master". Deleting this keyword argument instructs Documenter.jl to figure out the correct branch name automatically.