Review and fix CI failures on main branch #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
svilupp
commented
Nov 27, 2025
svilupp
commented
- Fix tests by aligning mock responses with the latest PromptingTools requirements
- dispose of test servers properly
Fixed test/preparation.jl line 68 where the embedding response was incorrectly formatted as a single dictionary with a 2D matrix instead of separate dictionaries with 1D vectors. This was causing CI failures after upgrading to PromptingTools v0.84+, which has stricter validation of API response formats. Changed from: - Dict(:embedding => ones(128, 2)) - single dict with 128x2 matrix To: - [Dict(:embedding => ones(Float32, 128)), Dict(:embedding => ones(Float32, 128))] - two dicts with 128-dim vectors This matches the correct OpenAI API format where each embedding is returned as a separate object in the data array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.