Add a cconvert for each unsafe_convert#234
Open
nhz2 wants to merge 3 commits intoJuliaLinearAlgebra:masterfrom
Open
Add a cconvert for each unsafe_convert#234nhz2 wants to merge 3 commits intoJuliaLinearAlgebra:masterfrom
nhz2 wants to merge 3 commits intoJuliaLinearAlgebra:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 89.93% 89.67% -0.27%
==========================================
Files 11 11
Lines 1113 1123 +10
==========================================
+ Hits 1001 1007 +6
- Misses 112 116 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Can we add tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the tests broken by changes in JuliaLang/julia#60533
A follow-up would organize things so that
Base.unsafe_convert(Ptr{T}, A.data)isn't called.But this PR should restore behavior to what it was before JuliaLang/julia#60533