fix bug in masked, multi-dimensional state space multi-threaded envs#900
Open
Graeme22 wants to merge 2 commits intoJuliaReinforcementLearning:mainfrom
Open
fix bug in masked, multi-dimensional state space multi-threaded envs#900Graeme22 wants to merge 2 commits intoJuliaReinforcementLearning:mainfrom
Graeme22 wants to merge 2 commits intoJuliaReinforcementLearning:mainfrom
Conversation
jeremiahpslewis
approved these changes
Jun 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #900 +/- ##
==========================================
- Coverage 24.47% 0.04% -24.44%
==========================================
Files 219 207 -12
Lines 7686 7361 -325
==========================================
- Hits 1881 3 -1878
- Misses 5805 7358 +1553
|
Member
|
@Graeme22 This looks like a good catch, thanks! Would you be able to contribute a test that would have caught the issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes what appears to be a copy/paste bug that affects multi-threaded envs where the state space of the wrapped environment has different dimensionality than the action space of that environment.
For an example environment that this breaks, see https://github.com/Graeme22/rlskedge
PR Checklist