Update descriptions for BFGS and SR1 operators#216
Merged
dpo merged 2 commits intoJuliaSmoothOptimizers:mainfrom Jan 26, 2026
Merged
Update descriptions for BFGS and SR1 operators#216dpo merged 2 commits intoJuliaSmoothOptimizers:mainfrom
dpo merged 2 commits intoJuliaSmoothOptimizers:mainfrom
Conversation
Separated the description of BFGS and SR1. Added an explanation of why the inverse form of the SR1 is not implemented.
dpo
reviewed
Jan 23, 2026
Comment on lines
355
to
356
| Note that the SR1 operator can be indefinite, therefore its inverse does not necessarily exist. | ||
| For this reason, the inverse form is not implemented for the SR1 operator. |
Member
There was a problem hiding this comment.
The LSR1 approximation is nonsingular, even if it can be indefinite. So its inverse is well defined. However, it's not particularly useful in optimization, precisely because it can be indefinite. That's why it's not implemented.
Contributor
Author
There was a problem hiding this comment.
Ha, you are right, I updated the comment.
Clarify the relevance of the inverse form for the SR1 operator compared to BFGS.
Member
|
@MaxenceGollier @dpo the right place to modify the tutorials is actually here: https://github.com/JuliaSmoothOptimizers/JSOTutorials.jl/tree/main/tutorials/introduction-to-linear-operators . Then, it automatically opens a PR to the website repository. |
Contributor
Author
|
Sorry, I did not know. Do i need to fix something there now ? |
Member
|
If you don't mind, yes. Otherwise we risk to erase your modification next time. Thanks!! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dpo, @amontoison
Separated the description of BFGS and SR1.
Added an explanation of why the inverse form of the SR1 is not implemented.
closes LinearOperators.jl#367.