Draft
Conversation
Member
Author
|
I think this one should go first, that way JuliaLang/julia#59025 can bump the hash as part of the same commit so there are no commits in |
Member
|
So do you want to merge this in first, and then include the SparseArrays bump on master? I'm ok to do that. I can invite you to this repo so that you can co-ordinate these without waiting on anyone. |
Member
Author
|
cool, thanks! The PR in Base is still awaiting code review (although the high level change is already triage-approved), but once that's completed this should simplify coordinating the two PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
would be paired with JuliaLang/julia#59025 to make
setindex!a bit more coherent