macOS: Also consider compressed pages as usable. #89
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be possible to put them in swap relatively cheaply.
Contributor
|
I guess my main question is do we expect users to expect to be able to use their device while running tests? If not then this is probably fine for a test package. |
Collaborator
Author
|
It doesn't kill the device, just makes it slightly sluggish while paging out stuff. I'd say that's acceptable, no? |
Contributor
|
Probably. And someone could always just set the # jobs manually to a value they know is safe if they need to keep using it. |
Collaborator
Author
|
Yeah. I say we try this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that on my system ParallelTestRunner only ever used a single worker. This because my memory usage is:
So only taking free + inactive + purgeable into account gives us 2.8G, only enough for a single worker, while adding the compressed pages brings it to 10G allowing 5 workers. AFAIU these compressed pages should be safe to ignore, as they can be swapped out. I verified here that given a 10GiB computation I can allocate a 10GiB array without killing my system (although it was a bit angry while swapping out the compressed pages).
cc @christiangnrd