Highlight in red name of failed test when showing output #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/output-generated-color
branch
from
07cd029 to
d2dfdca
Compare
giordano
commented
Feb 13, 2026
| if !isempty(output) | ||
| println(io_ctx.stdout, "\nOutput generated during execution of '$testname':") | ||
| print(io_ctx.stdout, "\nOutput generated during execution of '") | ||
| if result isa Exception || anynonpass(result.value) |
Collaborator
Author
There was a problem hiding this comment.
Maybe this could be limited to result isa Exception? Test failures should already be displayed somewhere else, but it's the output of crashed jobs which is more important to quickly find.
Collaborator
Author
There was a problem hiding this comment.
So with
Suggested change
| if result isa Exception || anynonpass(result.value) | |
| if result isa Exception |
we'd have
vchuravy
approved these changes
Feb 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I look through the output of tests, I'd like to quickly spot that of failed tests, and I think the colourful hint of the red name helps with this. What do you think?