Only bind mappings if they're not already used#477
Open
danebidev wants to merge 1 commit intoJulian:mainfrom
Open
Only bind mappings if they're not already used#477danebidev wants to merge 1 commit intoJulian:mainfrom
danebidev wants to merge 1 commit intoJulian:mainfrom
Conversation
Owner
|
Hey, thanks for giving this a shot -- this actually only does "half" of the job. Specifically we bind mappings in two places unfortunately the moment, here in |
Author
|
Should be correct now. Should I also put these other keymaps behind a check? |
Owner
Seems like it would be nice as well, yeah. I suspect the CI failures here are real now and would need looking at to see what's breaking. It also would be nice to add at least one new test for this behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting conflicts with some of my existing keybinds, and noticed that it was already planned (#456).