Add type to HTTP method and status enum #30
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add "quality-of-life" enhancement to backend development.
fetchHTTP request methods are constrained toGET,POST,PUT,PATCH, andDELETE. These methods align with Next.js route handlers specifications. Typescript can now provide us type hintsAdd a enum for common status code that I anticipated would be useful for our development. The idea is that it's easier to understand the intent of the status code from the enums, instead of trying to remember what all the numbers represent.
Possible Downsides
The type-hint for HTTP request methods doesn't raise a compilation error with typo - i.e someone can still type a bogus HTTP method.