Fix: out-of-date PMTContinuousObserver readings #283
Merged
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the power measurement stored in self.results, we should use those in self.parent.results. This will ensure we have the latest readings after continuous benchmarking (benchmark_continuous), instead of the figures measured during the benchmark_default run.
|
benvanwerkhoven
approved these changes
Dec 5, 2024
Collaborator
benvanwerkhoven
left a comment
benvanwerkhoven
left a comment
There was a problem hiding this comment.
Good catch! Thanks for submitting this pull request!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the power measurement stored in
self.results, we should use those inself.parent.results. This will ensure we have the latest readings after continuous benchmarking (benchmark_continuous), instead of the figures measured during thebenchmark_defaultrun.