Change Firefly algorithm to use negation instead of division #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Firefly computes particle intensity as `1 / score`, so a lower score gives a higher intensity. While this works for positive scores, it fails when scores can be negative. This commit switches the calculation to `-score`, which keeps the "higher intensity is better" behavior, but handles negative scores correctly.
benvanwerkhoven
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Firefly computes particle intensity as
1 / score, so a lower score gives a higher intensity. While this works for positive scores, it fails when scores can be negative.This commit changes the calculation to
-score, which keeps the "higher intensity is better" behavior, but handles negative scores correctly.@benvanwerkhoven