fix: TypeError when clicking range-slider filter in popover mode#535
Open
ZuebeyirEser wants to merge 1 commit intoKevinVandy:v2from
Open
fix: TypeError when clicking range-slider filter in popover mode#535ZuebeyirEser wants to merge 1 commit intoKevinVandy:v2from
ZuebeyirEser wants to merge 1 commit intoKevinVandy:v2from
Conversation
• Add type check before calling input.select() to prevent error on range-slider inputs that don't have select method
|
@ZuebeyirEser is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I use the MRT almost every day, I quickly identified the bug in #534 and provided a fix.
Bug Fix: TypeError in Range Slider Popover
Fixes #534
Issue
TypeError: input.select is not a functionoccurs when clicking filter button for range-slider columns in popover mode.Solution
Added type check before calling
input.select()to prevent error on range-slider inputs.Testing
See Storybook story:
Fixed Bugs/Range Slider Popover Bug