Skip to content

fix(row-selection): correct select-all checkbox state for manual pagination #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahulpatwa1303 wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

fix(row-selection): correct select-all checkbox state for manual pagination #1499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 40 additions & 4 deletions packages/material-react-table/src/components/inputs/MRT_SelectCheckbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,11 @@ export const MRT_SelectCheckbox = <TData extends MRT_RowData>({
muiSelectAllCheckboxProps,
muiSelectCheckboxProps,
selectAllMode,
manualPagination,
rowCount,
},
} = table;
const { density, isLoading } = getState();
const { density, isLoading, rowSelection } = getState();

const selectAll = !row;

Expand All @@ -49,8 +51,29 @@ export const MRT_SelectCheckbox = <TData extends MRT_RowData>({
: table.getIsAllRowsSelected()
: undefined;

const isVisuallyChecked =
selectAll && manualPagination && rowCount !== undefined
? Object.keys(rowSelection).length === rowCount
: allRowsSelected;

const isSomeRowsSelected = selectAll
? manualPagination && rowCount !== undefined
? Object.keys(rowSelection).length > 0 &&
Object.keys(rowSelection).length < rowCount
: selectAllMode === 'page' && table.getIsAllPageRowsSelected()
? false
: table.getIsSomeRowsSelected()
: undefined;

const shouldDeselect =
selectAll && manualPagination && rowCount !== undefined
? selectAllMode === 'page'
? table.getIsAllPageRowsSelected()
: Object.keys(rowSelection).length === rowCount
: allRowsSelected;

const isChecked = selectAll
? allRowsSelected
? isVisuallyChecked
: getIsRowSelected({ row, table });

const checkboxProps = {
Expand All @@ -74,6 +97,19 @@ export const MRT_SelectCheckbox = <TData extends MRT_RowData>({

const onSelectAllChange = getMRT_SelectAllHandler({ table });

const handleSelectAllChange = (event: any) => {
event.stopPropagation();
if (selectAll && manualPagination && rowCount !== undefined) {
const syntheticEvent = {
...event,
target: { ...event.target, checked: !shouldDeselect },
};
onSelectAllChange(syntheticEvent);
} else {
onSelectAllChange(event);
}
};

const commonProps = {
'aria-label': selectAll
? localization.toggleSelectAll
Expand All @@ -88,7 +124,7 @@ export const MRT_SelectCheckbox = <TData extends MRT_RowData>({
},
onChange: (event) => {
event.stopPropagation();
selectAll ? onSelectAllChange(event) : onSelectionChange!(event);
selectAll ? handleSelectAllChange(event) : onSelectionChange!(event);
},
size: (density === 'compact' ? 'small' : 'medium') as 'medium' | 'small',
...checkboxProps,
Expand Down Expand Up @@ -122,7 +158,7 @@ export const MRT_SelectCheckbox = <TData extends MRT_RowData>({
<Checkbox
indeterminate={
!isChecked && selectAll
? table.getIsSomeRowsSelected()
? isSomeRowsSelected
: row?.getIsSomeSelected() && row.getCanSelectSubRows()
}
{...commonProps}
Expand Down