-
Notifications
You must be signed in to change notification settings - Fork 0
feat: release 1.0 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the documentation and project configuration to rebrand the plugin from "HydrantId" to "HID Global" and add support for .NET 8.0. The CHANGELOG.md file has been reset to reflect the initial release, removing previous version history that appears to have been copied from another project (GCP CAS references).
Key changes:
- Rebranded plugin name from "HydrantId AnyCA Gateway REST Plugin" to "HID Global AnyCA Gateway REST Plugin"
- Added .NET 8.0 target framework support alongside existing .NET 6.0
- Expanded and reorganized documentation with detailed prerequisites, configuration steps, and security considerations
- Updated GitHub repository references from
hydrantid-cagatewaytohydrantid-caplugin - Cleaned up CHANGELOG.md to remove unrelated version history
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| integration-manifest.json | Updated release directory path and added release_project field |
| docsource/configuration.md | Comprehensive rewrite with expanded prerequisites, configuration details, and security guidance |
| README.md | Rebranded to HID Global, updated repository links, expanded documentation structure |
| HydrantCAProxy/HydrantIdCAPlugin.csproj | Added .NET 8.0 as additional target framework |
| CHANGELOG.md | Reset to initial v1.0.0 release, removed irrelevant GCP CAS version history |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "$schema": "https://keyfactor.github.io/v2/integration-manifest-schema.json", | ||
| "name": "HID Global AnyCA REST plugin", | ||
| "release_dir": "HydrantCAProxy/bin/Release/net6.0", | ||
| "release_dir": "HydrantCAProxy/bin/Release", |
Copilot
AI
Nov 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release_dir path no longer includes the target framework (net6.0), but the project now targets multiple frameworks (net6.0 and net8.0). This may cause issues during the build/release process as the build output will be in framework-specific subdirectories. Consider updating to 'HydrantCAProxy/bin/Release/net6.0' or configuring the build process to handle multi-targeting.
| "release_dir": "HydrantCAProxy/bin/Release", | |
| "release_dir": "HydrantCAProxy/bin/Release/net6.0", |
|
|
||
| # v1.0.0 | ||
| * Initial Release. Support for Google GA CA Service. Sync, Enroll, and Revocation. | ||
| * Initial Release. Sync, Enroll, and Revocation. |
Copilot
AI
Nov 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double space between 'Release.' and 'Sync' should be a single space.
| * Initial Release. Sync, Enroll, and Revocation. | |
| * Initial Release. Sync, Enroll, and Revocation. |
| * **HydrantIdAuthKey** - The AuthKey Obtained from HydrantId. | ||
| 2. Define [Certificate Profiles](https://software.keyfactor.com/Guides/AnyCAGatewayREST/Content/AnyCAGatewayREST/AddCP-Gateway.htm) and [Certificate Templates](https://software.keyfactor.com/Guides/AnyCAGatewayREST/Content/AnyCAGatewayREST/AddCA-Gateway.htm) for the Certificate Authority as required. One Certificate Profile must be defined per Certificate Template. It's recommended that each Certificate Profile be named after the Product ID. | ||
| 2. ### Template (Product) Configuration |
Copilot
AI
Nov 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid markdown structure: a numbered list item (2.) should not contain a heading (###). The heading should either be outside the list or the numbering should be removed. This will render incorrectly in most markdown parsers.
The HID Global HydrantId AnyCA Gateway REST plugin extends the capabilities of HydrantId Certificate Authority Service to Keyfactor Command via the Keyfactor AnyCA Gateway. This plugin leverages the HydrantId REST API with Hawk authentication to provide comprehensive certificate lifecycle management. The plugin represents a fully featured AnyCA Plugin with the following capabilities:
* **CA Sync**:
* Download all certificates issued by the HydrantId CA
* Support for incremental and full synchronization
* Automatic extraction of end-entity certificates from PEM chains
* **Certificate Enrollment**:
* Support certificate enrollment with new key pairs
* Dynamic policy (profile) discovery from the CA
* Intelligent renewal vs. re-issue logic based on certificate expiration
* Support for PKCS#10 CSR format
* Configurable certificate validity periods
* **Certificate Revocation**:
* Request revocation of previously issued certificates
* Support for standard CRL revocation reasons
---------
Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
No description provided.