Skip to content

Make DictionaryDomain compose with KhiopsJSONObject #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
popescu-v merged 1 commit into from
Jan 27, 2026
Merged

Make DictionaryDomain compose with KhiopsJSONObject #540

popescu-v merged 1 commit into from
Jan 27, 2026

Conversation

@popescu-v
Copy link
Collaborator

@popescu-v popescu-v commented Jan 27, 2026 •
edited
Loading

Thus, the adherence of DictionaryDomain to KhiopsJSONObject is reduced to the strict minimum required for:

  • initializing a DictionaryDomain from a JSON representation
  • writing a DictionaryDomain to a .kdic file, while taking into account the character encoding.

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@popescu-v popescu-v linked an issue Jan 27, 2026 that may be closed by this pull request
KhiopsDictionaryDomain JSON export method doesn't work. #535
Closed
folmos-at-orange
folmos-at-orange approved these changes Jan 27, 2026
View reviewed changes
@popescu-v
Make DictionaryDomain compose with KhiopsJSONObject
8a77931 
Thus, the adherence of DictionaryDomain to KhiopsJSONObject is reduced
to the strict minimum required for:
- initializing a DictionaryDomain from a JSON representation
- writing a DictionaryDomain to a .kdic file, while taking into account
  the character encoding.
@popescu-v popescu-v force-pushed the 535-khiopsdictionarydomain-json-export-method-doesnt-work branch from 77cdec7 to 8a77931 Compare January 27, 2026 15:45
@popescu-v popescu-v self-assigned this Jan 27, 2026
@popescu-v popescu-v merged commit 019b089 into dev Jan 27, 2026
18 of 23 checks passed
@popescu-v popescu-v deleted the 535-khiopsdictionarydomain-json-export-method-doesnt-work branch January 27, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folmos-at-orange folmos-at-orange folmos-at-orange approved these changes

@tramora tramora Awaiting requested review from tramora

Assignees

@popescu-v popescu-v

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

KhiopsDictionaryDomain JSON export method doesn't work.

3 participants

@popescu-v @folmos-at-orange