Skip to content

534 add missing attributes to khiopsregressor #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
popescu-v wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

534 add missing attributes to khiopsregressor #541

popescu-v wants to merge 2 commits into from

Conversation

@popescu-v
Copy link
Collaborator

@popescu-v popescu-v commented Jan 27, 2026 •
edited
Loading

Add n_trees, n_text_features and type_text_features to the KhiopsRegressor class docstring.
Drop spurious unsupported n_trees warning on KhiopsRegressor.
closes #534 , #520 .

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@popescu-v popescu-v linked an issue Jan 27, 2026 that may be closed by this pull request
Add Missing Attributes to KhiopsRegressor #534
Open
@popescu-v popescu-v self-assigned this Jan 27, 2026
@popescu-v popescu-v assigned tramora and unassigned tramora Jan 27, 2026
@popescu-v popescu-v requested a review from tramora January 27, 2026 16:21
folmos-at-orange
folmos-at-orange approved these changes Jan 27, 2026
View reviewed changes
@popescu-v
Document missing attributes on KhiopsRegressor
233433d 
Namely, n_trees, n_text_features and type_text_features.
@popescu-v
Drop spurious warning that trees are not supported for regression
851d504 
KhiopsRegressor fully supports the `n_trees` attribute.
@popescu-v popescu-v force-pushed the 534-add-missing-attributes-to-khiopsregressor branch from ec020dc to 851d504 Compare January 27, 2026 16:33
tramora
tramora approved these changes Jan 27, 2026
View reviewed changes
Copy link
Collaborator

@tramora tramora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tramora tramora tramora approved these changes

@folmos-at-orange folmos-at-orange folmos-at-orange approved these changes

Assignees

@popescu-v popescu-v

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Missing Attributes to KhiopsRegressor

4 participants

@popescu-v @tramora @folmos-at-orange