Conversation
…in-specific domains requiring extra setup fix the crash in the `calibrated_timestamps` sample reported in issue #1454. The issue was caused by the sample unconditionally querying and attempting to use all calibrateable time domains returned by the physical device. Specifically, `VK_TIME_DOMAIN_PRESENT_STAGE_LOCAL_EXT` and `VK_TIME_DOMAIN_SWAPCHAIN_LOCAL_EXT` require the `VK_EXT_present_timing` extension to be enabled and a `VkSwapchainCalibratedTimestampInfoEXT` structure to be provided in the `pNext` chain of `VkCalibratedTimestampInfoEXT`. Since the sample did not meet these requirements, it triggered validation errors and crashed on hardware supporting these domains (e.g., Nvidia RTX 40 series).
samples/extensions/calibrated_timestamps/calibrated_timestamps.cpp
Outdated
Show resolved
Hide resolved
SaschaWillems
requested changes
Jan 25, 2026
Collaborator
SaschaWillems
left a comment
There was a problem hiding this comment.
This does fix my crash, but I'm with Andreas on this. To future proof this, checking for the domains that are known to work would be the better option.
asuessenbach
approved these changes
Jan 26, 2026
SaschaWillems
approved these changes
Jan 26, 2026
gary-sweet
approved these changes
Jan 27, 2026
Collaborator
|
Merging this, otherwise I won't be able to do batch runs to review PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for additional Vulkan time domains while skipping swapchain-specific domains requiring extra setup
fix the crash in the
calibrated_timestampssample reported in issue #1454.The issue was caused by the sample unconditionally querying and attempting to use all calibrateable time domains returned by the physical device. Specifically,
VK_TIME_DOMAIN_PRESENT_STAGE_LOCAL_EXTandVK_TIME_DOMAIN_SWAPCHAIN_LOCAL_EXTrequire theVK_EXT_present_timingextension to be enabled and aVkSwapchainCalibratedTimestampInfoEXTstructure to be provided in thepNextchain ofVkCalibratedTimestampInfoEXT. Since the sample did not meet these requirements, it triggered validation errors and crashed on hardware supporting these domains (e.g., Nvidia RTX 40 series).Description
Please include a summary of the change, new sample or fixed issue. Please also include relevant motivation and context.
Please read the contribution guidelines
Fixes #1454
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: