Skip to content

Fix calibrated timestamps#1471

Merged
SaschaWillems merged 4 commits intomainfrom
fix-calibrated-timestamps
Feb 2, 2026
Merged

Fix calibrated timestamps#1471
SaschaWillems merged 4 commits intomainfrom
fix-calibrated-timestamps

Conversation

@gpx1000
Copy link
Collaborator

@gpx1000 gpx1000 commented Jan 19, 2026

Add support for additional Vulkan time domains while skipping swapchain-specific domains requiring extra setup

fix the crash in the calibrated_timestamps sample reported in issue #1454.

The issue was caused by the sample unconditionally querying and attempting to use all calibrateable time domains returned by the physical device. Specifically, VK_TIME_DOMAIN_PRESENT_STAGE_LOCAL_EXT and VK_TIME_DOMAIN_SWAPCHAIN_LOCAL_EXT require the VK_EXT_present_timing extension to be enabled and a VkSwapchainCalibratedTimestampInfoEXT structure to be provided in the pNext chain of VkCalibratedTimestampInfoEXT. Since the sample did not meet these requirements, it triggered validation errors and crashed on hardware supporting these domains (e.g., Nvidia RTX 40 series).

Description

Please include a summary of the change, new sample or fixed issue. Please also include relevant motivation and context.
Please read the contribution guidelines

Fixes #1454

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

gpx1000 and others added 3 commits January 19, 2026 15:38
…in-specific domains requiring extra setup

fix the crash in the `calibrated_timestamps` sample reported in issue #1454.

The issue was caused by the sample unconditionally querying and attempting to use all calibrateable time domains returned by the physical device. Specifically, `VK_TIME_DOMAIN_PRESENT_STAGE_LOCAL_EXT` and `VK_TIME_DOMAIN_SWAPCHAIN_LOCAL_EXT` require the `VK_EXT_present_timing` extension to be enabled and a `VkSwapchainCalibratedTimestampInfoEXT` structure to be provided in the `pNext` chain of `VkCalibratedTimestampInfoEXT`. Since the sample did not meet these requirements, it triggered validation errors and crashed on hardware supporting these domains (e.g., Nvidia RTX 40 series).
Copy link
Collaborator

@SaschaWillems SaschaWillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does fix my crash, but I'm with Andreas on this. To future proof this, checking for the domains that are known to work would be the better option.

@SaschaWillems
Copy link
Collaborator

Merging this, otherwise I won't be able to do batch runs to review PRs.

@SaschaWillems SaschaWillems merged commit 008a604 into main Feb 2, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calibrated timestamp samples crashing

4 participants