Skip to content

common: remove unused variable #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dabrain34 wants to merge 1 commit into from
Closed

common: remove unused variable #102

dabrain34 wants to merge 1 commit into from

Conversation

@dabrain34
Copy link
Contributor

@dabrain34 dabrain34 commented Sep 25, 2025 •
edited
Loading

Remove m_ycbcrPrimariesConstants which is
unused in the codebase.

@dabrain34
common: remove unused variable
9128baa 
Remove m_ycbcrPrimariesConstants which
unused in the codebase.
@dabrain34 dabrain34 requested a review from zlatinski September 25, 2025 11:43
@dabrain34
Copy link
Contributor Author

dabrain34 commented Sep 25, 2025 •
edited
Loading

Hello @zlatinski I opened this MR to discuss the use m_ycbcrPrimariesConstants which is unused in VulkanFilterYuvCompute.cpp.

It allows to avoid a warning on Windows building this with CTS.

Can you give your input on what you prefer to do with this unused variable ?

This patch is necessary for #103

zlatinski
zlatinski requested changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@zlatinski zlatinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality is to be extended in the future and those parameters are needed.
You can always replace:
"const YcbcrPrimariesConstants* pYcbcrPrimariesConstants," with
const YcbcrPrimariesConstants*, to quiet down these warnings, without hanging the function's APIs.

@dabrain34
Copy link
Contributor Author

dabrain34 commented Oct 14, 2025 •
edited
Loading

I gave another try and I havent been able to reproduce the build issue with the latest main of CTS and the use of #103

Closing.

@dabrain34 dabrain34 closed this Oct 14, 2025
@dabrain34
Copy link
Contributor Author

dabrain34 commented Nov 28, 2025

able to reproduce with:

python3 scripts/check_build_sanity.py --skip-prerequisites -r clang-64-debug -t ./tmp.PiN3LHSb8Z

@dabrain34 dabrain34 mentioned this pull request Nov 28, 2025
Merged
dabrain34 added a commit to dabrain34/Vulkan-Video-Samples that referenced this pull request Dec 4, 2025
@dabrain34
common: remove warning for unused variable
a409530 
Void m_ycbcrPrimariesConstants which
unused in the codebase but kept for future
implementation.

See KhronosGroup#102
dabrain34 added a commit that referenced this pull request Dec 4, 2025
@dabrain34
common: remove warning for unused variable
bb78b0d 
Void m_ycbcrPrimariesConstants which
unused in the codebase but kept for future
implementation.

See #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zlatinski zlatinski zlatinski requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dabrain34 @zlatinski