common: Fix 10-bit and 12-bit sample normalization in ConvertFrameToNv12 #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
High bit-depth video samples (10-bit and 12-bit) decoded are stored MSB-aligned in 16-bit words, with undefined bits in the lower positions (6 bits for 10-bit, 4 bits for 12-bit). The existing ConvertFrameToNv12 function copies these samples directly without normalizing the bit positions, resulting in incorrect output data. This also fixes failures of av1 10-bit decode tests in fluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High bit-depth video samples (10-bit and 12-bit) decoded are stored MSB-aligned in 16-bit words, with undefined bits in the lower positions (6 bits for 10-bit, 4 bits for 12-bit). The existing ConvertFrameToNv12 function copies these samples directly without normalizing the bit positions, resulting in incorrect output data.
This also fixes failures of av1 10-bit decode tests in fluster.