Add support for cross-queue family transfer operations #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using linear output mode (ENABLE_LINEAR_OUTPUT), the decoder needs to copy decoded frames from optimal to linear images using a transfer operation. The original implementation assumed the transfer queue and video decode queue were in the same queue family, recording the copy operation directly in the decode command buffer. On some devices (e.g., Intel ANV), the video decode queue and transfer queue are in different queue families. This requires proper queue family ownership transfer using release/acquire barriers and semaphore synchronization between the queues.
…support Even if without noPresent, if the option -o is provided, we need to try to create a transfer queue when video decode queue lacks transfer support.
Contributor
|
There was already an attempt pending to fix this issue in #34 but the conclusion is that we should implement a transfer filter, see comment #34 (comment) Or use --enablePostProcessFilter 0 as an option to support ANV and RADV |
Contributor
Author
Urg.. Didn't notice that. I'll look into the transfer filter to do this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using linear output mode (ENABLE_LINEAR_OUTPUT), the decoder needs to
copy decoded frames from optimal to linear images using a transfer operation.
The original implementation assumed the transfer queue and video decode queue
were in the same queue family, recording the copy operation directly in the
decode command buffer.
On some devices (e.g., Intel ANV), the video decode queue and transfer queue
are in different queue families. This requires proper queue family ownership
transfer using release/acquire barriers and semaphore synchronization between
the queues.