Vulkan Video VP9 decode support #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think you should rebase the branch on top of main as I changed some commits to support the release process. ci: update ci scripts to generate zip files should be removed |
Contributor
|
Add option to generate raw YUV frames I dont think this commit is necessary in this VP9 decode PR as other commits which should be split to other PRs. |
Contributor
Author
These were all coming from the VP9 branch. I just squashed the VP9-specific one and left the others alone. These other changes are still needed to VP9 to function correctly. I can remove the "generate raw YUV frames", if required. |
Contributor
Contributor
zlatinski
force-pushed
the
vp9-decode-support
branch
from
43ae63f to
5530ad4
Compare
Contributor
|
I tested VP9 CTS with this series and seems fine. Thanks! |
Contributor
|
There are typos in the commit message of:
Can you please add a prefix to the commit. It helps to understand it too. Planning to add all these coding rules in #58 |
zlatinski
force-pushed
the
vp9-decode-support
branch
from
5530ad4 to
44f1d05
Compare
Contributor
Author
Sorry, I should have caught these types while doing the rebase. Now those are fixed. |
zlatinski
force-pushed
the
vp9-decode-support
branch
from
44f1d05 to
e762bc7
Compare
dabrain34
force-pushed
the
vp9-decode-support
branch
from
e762bc7 to
067300b
Compare
For chroma resolution in 420 or 422 format, round width/height to the next integer when calculating from luma width and height.
Remove assert when fence times out but the timeout value is less than the total wait time.
Instead of defining the destructor inline, provide its implementation in a separate source file to make GCC 13 happy in release mode. Also fix other compilation errors in release mode. Signed-off-by: Raju Konda <kraju@nvidia.com>
Calculate the chroma plane width separately, and add the U and V widths to get the final UV plane width in NV12.
Use VkSubmitInfo2KHR and use TL semaphores in both encoder and decoder.
Update vp9 decode headers VK_KHR_video_decode_vp9 spec update Fix offset of frames in super frame for parsing and decoding VP9 Decode: Derive UsePrevFrameMvs VP9 Decode: Use previous loop filter values when not coded Fix self assignment of renderHeight when frame and render sizes are different resolution change fixes Handle alignment of bitstream offset for frames in super frame VP9 Decode: Use correct constants for DPB state arrays Fix output DISTINCT case for VP9 After recent changes related to codedExtent in VP9, the output distinct case was broken, since the codedExtent for the dstPictureResource is not set. In the COINCIDE case, the dstPictureResource is copied from the reference resource. Fix preparing ref_frame_sign_bias bitmask Display an existing frame when show_existing_frame is set and skip HW decode Fix parsing of profile Fix conversion of 12-bit chroma format from ffmpeg values to vulkan video. Unify display logic for show_frame and show_existing_frame. App runs fine if a frame is displayed once or not displayed. It crashes if a frame is displayed more than once (example clip: vp90-2-10-show-existing-frame.webm). Fix odd resolution frame decoding VulkanVideoDecoder: Fix VP9 include name The VP9 include file uses upper case. VP9 Decoder: use different bitstreamBuffer than the buffer used in previous frame decoding Use override for VulkanVP9Decoder Remove useless av1 includes Remove StdVideoDecodeVP9ReferenceInfo Cleanup ParseFrameHeader interface Set UsePrevFrameMvs to 0 when frame size is changed Parse VP9 10bit profile correctly in header parser Make sure to retrive the VP9 10bit profile correctly as value 2 in the parser VP9Decode: fill BitDepth in pStdColorConfig Remove BitDepth in VkParserVp9PictureData Use maximum of frame width/height and render width/height for vp9 session VP9Decoder: set codecProfile in nvsi nvsi.codecProfile was always 0 and might be used by a parser client (CTS). Enable requested video codec extension by adding it to required extension list. Enable maintenance1 extension. Add it to optional extension list. Cleanup code to get codec type to chose decode extension list earlier. Align source buffer range to the multiple of minBitstreamBufferSizeAlignment Remove the local headers
Include pSetupReferenceSlot in the VkVideoBeginCodingInfoKHR::pReferenceSlots list when it is not null.
dabrain34
force-pushed
the
vp9-decode-support
branch
from
067300b to
321f336
Compare
Contributor
I created a MR #58 to add some jobs including git message check using gitling and code style based on clang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Vulkan Video VP9 decode
The base changes required to support VP9 decode have been added.
Added VP9-decode-specific changes
Unfortunately, the Vulkan SDK with VP9 is not available yet.
The latest version of the Vulkan (video) headers is required.
Please make sure to update the headers by removing the old ones.
rm -rf ./build/_deps/vulkan-headers*