Skip to content

Commit ab7ed9b

Browse files
committed
fix: remove ColumnCatalog Eq impl
1 parent e8e9239 commit ab7ed9b

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

src/catalog/column.rs

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use crate::types::{ColumnId, IdGenerator, LogicalType};
77

88
pub type ColumnRef = Arc<ColumnCatalog>;
99

10-
#[derive(Debug, Clone, Serialize, Deserialize, Hash)]
10+
#[derive(Debug, Clone, Serialize, Deserialize, Hash, Eq, PartialEq)]
1111
pub struct ColumnCatalog {
1212
pub id: ColumnId,
1313
pub name: String,
@@ -16,19 +16,6 @@ pub struct ColumnCatalog {
1616
pub desc: ColumnDesc,
1717
}
1818

19-
// Tips: When there is a Join, the on condition in the Join has a nullable condition,
20-
// and the nullable in the Projection will change after being affected by the JoinType,
21-
// so that Eq does not necessarily match, so only use the ID as the matching criterion
22-
impl PartialEq<Self> for ColumnCatalog {
23-
fn eq(&self, other: &Self) -> bool {
24-
self.id == other.id
25-
}
26-
}
27-
28-
impl Eq for ColumnCatalog {
29-
30-
}
31-
3219
impl ColumnCatalog {
3320
pub(crate) fn new(column_name: String, nullable: bool, column_desc: ColumnDesc) -> ColumnCatalog {
3421
ColumnCatalog {

0 commit comments

Comments
 (0)