Merged
Conversation
adamchalmers
force-pushed
the
achalmers/remove-cruft
branch
from
8a56aad to
fff47ff
Compare
adamchalmers
force-pushed
the
achalmers/remove-cruft
branch
from
fff47ff to
7af62fe
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Allow it to accept the same string inputs as kittycad::types does.
adamchalmers
force-pushed
the
achalmers/remove-cruft
branch
from
7af62fe to
d13db63
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1099 +/- ##
=======================================
Coverage ? 30.03%
=======================================
Files ? 34
Lines ? 1588
Branches ? 0
=======================================
Hits ? 477
Misses ? 1111
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jtran
approved these changes
Feb 20, 2026
adamchalmers
added a commit
that referenced
this pull request
Feb 21, 2026
# Removed - Conversions between the file format types in modeling-cmds and kittycad.rs (#1099)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI was using these conversion features, I've integrated this PR into CLI here: KittyCAD/cli#1479