Added Table Name by Krish-cloudsufi · Pull Request #1 · Krish-cloudsufi/snowflake-plugins

Krish-cloudsufi · 2025-03-24T08:26:20Z

Key changes :-

Added Table Name in properties
Modified Schema retrieval using table name and importQuery

AbhishekKumar9984 · 2025-03-27T11:36:34Z

src/main/java/io/cdap/plugin/snowflake/common/client/SnowflakeAccessor.java

+
+  public List<SnowflakeFieldDescriptor> describeTable(String schemaName, String tableName) throws SQLException {
+    List<SnowflakeFieldDescriptor> fieldDescriptors = new ArrayList<>();
+


don't left unwanted blank spaces.

This formatting was present in the original code as well, to maintain readability

single lines can be added not double blank lines

AbhishekKumar9984 · 2025-03-27T11:44:41Z

src/main/java/io/cdap/plugin/snowflake/common/util/SchemaHelper.java

      }
-      return Strings.isNullOrEmpty(importQuery) ? null : getSchema(snowflakeAccessor, importQuery);
-    } catch (SchemaParseException e) {
+      return getSchema(snowflakeAccessor, tableName, importQuery);


try to wrap this in a ternary operator as in the main file.So that null exception will be handled properly.

AbhishekKumar9984 · 2025-03-27T11:47:20Z

src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeBatchSourceConfig.java

+                                    @Nullable String schema,
+                                    @Nullable String tableName) {
+    super(
+      accountName, database, schemaName, username, password, keyPairEnabled, path, passphrase,


maintain indentation

vikasrathee-cs · 2025-04-07T06:26:52Z

src/main/java/io/cdap/plugin/snowflake/common/util/SchemaHelper.java

 import io.cdap.plugin.snowflake.source.batch.SnowflakeBatchSourceConfig;
 import io.cdap.plugin.snowflake.source.batch.SnowflakeInputFormatProvider;
 import io.cdap.plugin.snowflake.source.batch.SnowflakeSourceAccessor;
+


remove this blank line

vikasrathee-cs · 2025-04-07T06:30:30Z

src/main/java/io/cdap/plugin/snowflake/common/util/SchemaHelper.java

    }
  }

+  private static Schema getSchema(SnowflakeAccessor snowflakeAccessor, String tableName, String importQuery) {


Add @nullable in front of tableName and importQuery where ever it can be null in input params

vikasrathee-cs · 2025-04-07T06:31:23Z

src/main/java/io/cdap/plugin/snowflake/sink/batch/SnowflakeSinkConfig.java

  @Name(PROPERTY_TABLE_NAME)
  @Description("Name of the table to insert records into.")
  @Macro
+  @Nullable


not required on sink side

is this addressed?

This tableName property was present in the original repository on sink side, should I remove it?

no, remove @nullable annotation

vikasrathee-cs · 2025-04-07T06:32:08Z

src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeBatchSourceConfig.java


+  @Name(PROPERTY_TABLE_NAME)
+  @Nullable
+  @Description("The table name.")


add a little more description here and in md file

vikasrathee-cs · 2025-04-15T13:04:57Z

widgets/Snowflake-batchsource.json

+    {
+      "name": "ImportQuery",
+      "condition": {
+        "expression": "importQueryType == 'importQuery'"


make this condition != 'tableName', in that case it will work for null in case of upgrade

vikasrathee-cs · 2025-04-15T13:05:28Z

widgets/Snowflake-batchsource.json

-          "label": "Import Query",
+          "label": "Native Query",
          "name": "importQuery",
+          "widget-attributes": {


no default value, remove this

vikasrathee-cs · 2025-04-15T13:06:08Z

widgets/Snowflake-batchsource.json

        {
          "widget-type": "textarea",
-          "label": "Import Query",
+          "label": "Native Query",


Keep the label import query only

vikasrathee-cs · 2025-04-15T13:07:00Z

widgets/Snowflake-batchsource.json

+            "options": [
+              {
+                "id": "importQuery",
+                "label": "Native Query"


here you can keep the label as it is.

vikasrathee-cs · 2025-04-15T13:08:01Z

src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeBatchSourceConfig.java

+  @Description("The name of the table used to retrieve the schema.")
+  private final String tableName;
+
+  @Name("importQueryType")


make it macro and importQueryType should be Constant

Add this plugin property to .md files well. Add to SnowflakeSinkConfig as well.

vikasrathee-cs · 2025-04-15T13:09:03Z

src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeBatchSourceConfig.java

+  private final String tableName;
+
+  @Name("importQueryType")
+  @Description("Choose between Table Name or Import Query")


whether to select Table Name or Import Query to extract the data.

sgarg-CS · 2025-04-16T02:51:23Z

widgets/Snowflake-batchsource.json

+              },
+              {
+                "id": "tableName",
+                "label": "Named Table"


Also the label name should be consistent. In Source widget, it's Named Table while in sink it's Table Name

For the options we are keeping it as "Named Table" and for the tableName property it is kept as "Table Name".

sgarg-CS · 2025-04-16T02:52:19Z

widgets/Snowflake-batchsource.json

          "name": "role"
        },
+        {
+          "name": "importQueryType",


Add the importQueryType radio button for Snowflake-batchsink.json as well.

I think it's not required on sink side

In case it's not required on the sink plugin, then you can ignore the above comment.

sgarg-CS · 2025-04-16T02:57:08Z

widgets/Snowflake-batchsource.json

+          "widget-type": "radio-group",
+          "widget-attributes": {
+            "layout": "inline",
+            "default": "importQuery",


While getting the schema, we're checking for the tableName first and then the importQuery, so shouldn't tableName be the default value for the importQueryType ?

It was asked to keep the importQuery as default

vikasrathee-cs · 2025-04-17T11:35:57Z

src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeBatchSourceConfig.java

+
+  @Name("importQueryType")
+  @Description("Whether to select Table Name or Import Query to extract the data.")
+  @Macro


Make it Nullable for upgrade

AbhishekKumar9984 reviewed Mar 27, 2025

View reviewed changes

Repository owner deleted a comment from AbhishekKumar9984 Mar 28, 2025

vikasrathee-cs reviewed Apr 7, 2025

View reviewed changes

vikasrathee-cs reviewed Apr 15, 2025

View reviewed changes

sgarg-CS reviewed Apr 16, 2025

View reviewed changes

vikasrathee-cs reviewed Apr 17, 2025

View reviewed changes

Added Named Table option to fetch schema

4dcd391

vikasrathee-cs force-pushed the table branch from 8284389 to 4dcd391 Compare April 17, 2025 16:31


		public List<SnowflakeFieldDescriptor> describeTable(String schemaName, String tableName) throws SQLException {
		List<SnowflakeFieldDescriptor> fieldDescriptors = new ArrayList<>();

Conversation

Krish-cloudsufi commented Mar 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Krish-cloudsufi Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vikasrathee-cs Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sgarg-CS Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Krish-cloudsufi Apr 15, 2025 •

edited

Loading

vikasrathee-cs Apr 15, 2025 •

edited

Loading

sgarg-CS Apr 16, 2025 •

edited

Loading