Added optional LoRA adapter support for vLLM inference.#66
Open
ViktoriaNov wants to merge 3 commits intomainfrom
Open
Added optional LoRA adapter support for vLLM inference.#66ViktoriaNov wants to merge 3 commits intomainfrom
ViktoriaNov wants to merge 3 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
|
Please add some tests for the new feature, to satisfy the target code coverage (81.25%) |
DzmitryPihulski
requested changes
Feb 7, 2026
llmsql/inference/inference_vllm.py
Outdated
Comment on lines
74
to
78
| # === LoRA Parameters === | ||
| lora_path: str | None = None, | ||
| lora_name: str = "default", | ||
| lora_scale: float = 1.0, | ||
| max_lora_rank: int = 64, |
Collaborator
There was a problem hiding this comment.
We can change this parameters to the lora_params as the optional dict for the LoRA arguments to pass to the class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.