Skip to content

Conversation

@ostephens
Copy link
Contributor

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Closes #190

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
Replaces contractions with full words or phrases in line with Carpentry writing style guidance and lesson review feedback

If any relevant discussions have taken place elsewhere, please provide links to these.
carpentries-lab/reviews#33

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-marcedit/compare/md-outputs..md-outputs-PR-196

The following changes were observed in the rendered markdown documents:

 02-top-level-menu-features.md         |  4 ++--
 03-working-with-MARC-files.md         |  2 +-
 04-layout-of-the-MarcEditor.md        |  2 +-
 05-profiling-your-MARC-data.md        |  6 +++---
 06-manipulating-MARC-data-basics.md   | 10 +++++-----
 07-manipulating-MARC-data-advanced.md | 14 +++++++-------
 08-tasks-and-automation.md            |  8 ++++----
 09-integrations.md                    |  2 +-
 md5sum.txt                            | 18 +++++++++---------
 setup.md                              |  4 ++--
 10 files changed, 35 insertions(+), 35 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2026-01-23 16:02:33 +0000

github-actions bot pushed a commit that referenced this pull request Jan 23, 2026
Copy link
Contributor

@jenmawe jenmawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Copy link
Contributor

@abigailsparling abigailsparling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to rename some of the exercises? "Let us" sounds a bit awkward to me now that it's spelt out. What do others think about adjusting and removing "Let us".

Ex. "Add a shortcut to the main window" instead of "Let us add a shortcut to our main window"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace contractions with fully spelt out words

4 participants