Skip to content

Comments

feat: signature confirmation steps#6983

Draft
vitormattos wants to merge 7 commits intomainfrom
feat/signature-confirmation-steps
Draft

feat: signature confirmation steps#6983
vitormattos wants to merge 7 commits intomainfrom
feat/signature-confirmation-steps

Conversation

@vitormattos
Copy link
Member

No description provided.

- Add identityVerified state to control Step 3 visibility
- Update dialogTitle computed property for Step 3 title
- Update progressText to show 'Step 3 of 3 - Signature confirmation'
- Modify sendCode() to set identityVerified = true
- Add signDocument() method to trigger signature
- Add requestNewCode() to reset identityVerified state
- Add CSS styling for verification success message block

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Add identityVerified state to control Step 3 visibility
- Update dialogTitle computed property for Step 3 title
- Update progressText to show 'Step 3 of 3 - Signature confirmation'
- Modify sendToken() to set identityVerified = true
- Add signDocument() method to trigger signature
- Add requestNewToken() to reset identityVerified state
- Add CSS styling for verification success message block
- Match ModalEmailManager implementation for consistency

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Create new test file for ModalEmailManager component
- Update progress text assertions from 'Step 1 of 2' to 'Step 1 of 3'
- Update progress text assertions from 'Step 2 of 2' to 'Step 2 of 3'
- Add test: updates to step 3 when identityVerified is true
- Add test: shows verification success message on step 3
- Add test: shows correct button label on step 3
- Add test: sendCode sets identityVerified to true
- Add test: requestNewCode resets identityVerified to false

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Create new test file for ModalTokenManager component
- Update progress text assertions from 'Step 1 of 2' to 'Step 1 of 3'
- Update progress text assertions from 'Step 2 of 2' to 'Step 2 of 3'
- Add test: updates to step 3 when identityVerified is true
- Add test: shows verification success message on step 3
- Add test: shows correct button label on step 3
- Add test: sendToken sets identityVerified to true
- Add test: requestNewToken resets identityVerified to false
- Mirror ModalEmailManager test structure for consistency

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Create new test file for SignFinalModals component
- Fix import statement to use ES6 import instead of require
- Import useSignMethodsStore for component testing
- Add test structure for signature confirmation modals

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Add missing capability structure for sign-elements in test environment
- Set can-create-signature to true to allow dynamic signature tests
- Ensures needCreateSignature computed property returns correct value

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Update getCapabilities mock to return proper capability structure
- Include libresign.config.sign-elements.can-create-signature = true
- Fixes test failure: 'updates elements when signature is created dynamically'
- Ensures all 1648 tests pass without failures

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos added this to the Next Major (34) milestone Feb 20, 2026
@vitormattos vitormattos self-assigned this Feb 20, 2026
@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Feb 20, 2026
@vitormattos
Copy link
Member Author

close #6962

@vitormattos
Copy link
Member Author

/backport to stable33

@vitormattos
Copy link
Member Author

/backport to stable32

@vitormattos vitormattos marked this pull request as draft February 20, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 0. Needs triage

Development

Successfully merging this pull request may close these issues.

1 participant