Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-cloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: ["ubuntu-22.04", "macOS-13", "windows-2022"]
os: ["ubuntu-22.04", "macOS-14", "windows-2022"]
python-version: ["3.10"]
requires: ["latest"]
include:
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/ci-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ on: # Trigger the workflow on push or pull request, but only for the main branch
schedule:
- cron: "0 0 * * *" # every day at midnight UTC

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

defaults:
run:
shell: bash
Expand All @@ -18,20 +22,21 @@ jobs:
strategy:
fail-fast: false
matrix:
os: ["ubuntu-24.04", "macOS-13", "windows-2022"]
os: ["ubuntu-24.04", "macOS-14", "windows-2022"]
python-version: ["3.9", "3.12"]
requires: ["latest"]
dependency: ["lightning"]
include:
- { os: "ubuntu-22.04", python-version: "3.9", requires: "oldest", dependency: "lightning" }
- { os: "ubuntu-24.04", python-version: "3.12", requires: "latest", dependency: "pytorch_lightning" }
- { os: "windows-2022", python-version: "3.12", requires: "latest", dependency: "pytorch_lightning" }
- { os: "macOS-13", python-version: "3.12", requires: "latest", dependency: "pytorch_lightning" }
- { os: "macOS-14", python-version: "3.12", requires: "latest", dependency: "pytorch_lightning" }

# Timeout: https://stackoverflow.com/a/59076067/4521646
timeout-minutes: 35
env:
TORCH_URL: "https://download.pytorch.org/whl/cpu/torch_stable.html"
DISABLE_MPS: ${{ matrix.os == 'macOS-14' && '1' || '0' }}

steps:
- uses: actions/checkout@v5
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ markers = [
]
filterwarnings = [
"error::FutureWarning",
"ignore:`isinstance\\(treespec, LeafSpec\\)` is deprecated.*:FutureWarning",
]
xfail_strict = true
junit_duration_report = "call"
Expand Down
3 changes: 2 additions & 1 deletion tests/test_io_cloud.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@

@pytest.mark.parametrize("name", ["/too/many/slashes", "org/model", "model-name"])
@pytest.mark.parametrize("in_studio", [True, False])
def test_upload_wrong_model_name(name, in_studio, monkeypatch):
@mock.patch("litmodels.io.cloud.sdk_upload_model")
def test_upload_wrong_model_name(mock_sdk_upload, name, in_studio, monkeypatch):
if in_studio:
# mock env variables as it would run in studio
monkeypatch.setenv("LIGHTNING_ORG", LIT_ORG)
Expand Down
Loading