Fix G43.x - G49 in active gcodes#3813
Conversation
|
Relates to #3792 |
|
Note that there is similar code for state flags which is not modified in this PR: linuxcnc/src/emc/rs274ngc/interp_write.cc Line 281 in f82c475 linuxcnc/src/emc/rs274ngc/rs274ngc_pre.cc Line 2212 in f82c475 |
8fe3aa5 to
ad60626
Compare
ad60626 to
d743703
Compare
d743703 to
e6d0e2f
Compare
Current behavior shows 'G49' if current tool offset values are all zero and 'G43' if not. 'G43.1' and 'G43.2' are both shown as 'G43'. With this change we show 'G43', 'G43.1', 'G43.2' after the respective command 'G49' after g49 command Note that nothing is shown on startup unless it (eg 'G49') is found in RS274NGC_STARTUP_CODE.
e6d0e2f to
4b2e51c
Compare
|
@rmu75 If you can think of a better approach please let me know. |
|
My initial idea was to add a flag to the offsets, i.e. a "fake" offset. |
That was my initial idea as well but then I thought it would be nice to have 'active gcodes' reflect G43.1 and G43.2 as well. Do you know of a way to tell if we have a Startup vs Abort event? |
|
That code here https://github.com/Sigma1912/linuxcnc/blob/4b2e51c12bcf470fba63e9d9070295c9f66cb9ab/src/emc/rs274ngc/interp_write.cc#L133 suggests block should be set if it is an abort... if it is not, sorry, no idea. |
|
Replaced by #3816 |
Current behavior shows active gcode 'G49' if current tool offset values are all zero and 'G43' if not. This leads to incorrect information if we use G43 on a tool with all zero offsets and shows 'G43' for all g43.x commands.
With this change we show
'G43', 'G43.1', 'G43.2' after the respective command
'G49' after g49 command
Note that nothing is shown at startup unless it (eg 'G49') is found in RS274NGC_STARTUP_CODE.