Skip to content

refactor(views): use dict literals for donation_methods#490

Merged
ReenigneArcher merged 1 commit intomasterfrom
fix/views
Feb 16, 2026
Merged

refactor(views): use dict literals for donation_methods#490
ReenigneArcher merged 1 commit intomasterfrom
fix/views

Conversation

@ReenigneArcher
Copy link
Member

Description

Replace nested dict(...) constructor usage with dict literals in DonateCommandView.donation_methods for improved readability and consistent formatting (added trailing commas and uniform quoting). No functional changes intended.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Replace nested dict(...) constructor usage with dict literals in DonateCommandView.donation_methods for improved readability and consistent formatting (added trailing commas and uniform quoting). No functional changes intended.
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.09%. Comparing base (4720189) to head (fbec416).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #490   +/-   ##
=======================================
  Coverage   60.09%   60.09%           
=======================================
  Files          25       25           
  Lines        1812     1812           
=======================================
  Hits         1089     1089           
  Misses        723      723           
Files with missing lines Coverage Δ
src/discord_bot/views.py 37.30% <100.00%> (ø)

@ReenigneArcher ReenigneArcher merged commit dccfc7a into master Feb 16, 2026
17 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/views branch February 16, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant