Skip to content

Conversation

@Hirogen
Copy link
Collaborator

@Hirogen Hirogen commented Jan 22, 2026

This pull request improves backward compatibility for highlight group and entry settings by adding support for legacy property names (with typos) when importing old settings files. It also updates JSON serialization for highlight groups to use a more consistent and modern approach. The most important changes are:

Backward compatibility for highlight settings:

  • Added legacy properties (HilightGroupList and HilightEntryList) to the Preferences and HighlightGroup classes, respectively, to support importing old settings files that used incorrect property names. These properties redirect data to the correct properties and are marked as obsolete for future removal. [1] [2]
  • Added legacy properties (HilightEntryList and HilightGroupList) to the Settings class to support settings files that had these lists at the root level. These properties redirect data to the correct location in Preferences and are also marked as obsolete.

JSON serialization improvements:

  • Updated the SaveHighlightGroupsAsJSON method in ConfigManager.cs to use JsonConvert.SerializeObject with indented formatting and UTF-8 encoding for more consistent and readable JSON output.

Dependency and import updates:

  • Added missing using statements for highlight-related classes in Settings.cs to ensure all entities are available for serialization and deserialization.

@Hirogen Hirogen linked an issue Jan 22, 2026 that may be closed by this pull request
BRUNER Patrick and others added 2 commits January 22, 2026 16:34
@Hirogen Hirogen merged commit c458feb into Development Jan 22, 2026
1 check passed
@Hirogen Hirogen deleted the highlightbackwardscompatibility branch January 22, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot import setting from 1.9 in 1.21

2 participants