Add the source uri argument to ResolveRequire

[periapsises]

This lets plugins determine the URI of the file trying to require another.
It allows searching paths relative to that file.

[gemini-code-assist]

Summary of Changes

Hello @periapsises, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the module resolution system by passing the source URI to the ResolveRequire plugin dispatch. This change provides crucial context to plugins, enabling them to resolve module paths more intelligently, particularly for relative imports, thereby improving the flexibility and accuracy of the module loading mechanism.

Highlights

• Enhanced ResolveRequire plugin dispatch: The ResolveRequire plugin dispatch now receives the source URI (suri) as an argument, allowing plugins to determine the URI of the file initiating the require operation.
• Improved path resolution context: By providing the source URI, plugins can now perform more accurate path resolution, especially when searching for modules relative to the requiring file.
• Function signature update: The searchUrisByRequireName function's signature was updated to include the new suri parameter.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• script/workspace/require-path.lua
  • Modified the searchUrisByRequireName function to accept an additional suri parameter.
  • Updated the call to plugin.dispatch('ResolveRequire') to include the new suri argument.
  • Adjusted the findUrisByRequireName function to pass the suri to searchUrisByRequireName.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the source URI to the ResolveRequire plugin event, allowing plugins to have more context about where a require call originates. The implementation correctly threads the new suri parameter through searchUrisByRequireName to the plugin.dispatch call. No security vulnerabilities were found. The primary feedback is to update the LuaDoc for the modified function to include the new parameter, which will help with code clarity and future maintenance.