-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: composio drive connector #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…and update return values for indexing functions
|
@AnishSarkar22 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by RecurseML
🔍 Review performed on 09f570c..3af4fd0
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (23)
• surfsense_backend/app/connectors/composio_google_drive_connector.py
• surfsense_backend/app/routes/notifications_routes.py
• surfsense_backend/app/routes/search_source_connectors_routes.py
• surfsense_backend/app/services/notification_service.py
• surfsense_backend/app/tasks/composio_indexer.py
• surfsense_web/app/dashboard/[search_space_id]/new-chat/[[...chat_id]]/page.tsx
• surfsense_web/atoms/chat/current-thread.atom.ts
• surfsense_web/components/assistant-ui/assistant-message.tsx
• surfsense_web/components/assistant-ui/connector-popup/config/connector-status-config.json
• surfsense_web/components/assistant-ui/markdown-text.tsx
• surfsense_web/components/assistant-ui/thread.tsx
• surfsense_web/components/chat-comments/comment-item/comment-item.tsx
• surfsense_web/components/layout/hooks/SidebarContext.tsx
• surfsense_web/components/layout/hooks/index.ts
• surfsense_web/components/layout/providers/LayoutDataProvider.tsx
• surfsense_web/components/layout/ui/shell/LayoutShell.tsx
• surfsense_web/components/layout/ui/sidebar/InboxSidebar.tsx
• surfsense_web/components/tool-ui/audio.tsx
• surfsense_web/components/tool-ui/generate-podcast.tsx
• surfsense_web/hooks/use-inbox.ts
• surfsense_web/lib/apis/notifications-api.service.ts
• surfsense_web/messages/en.json
• surfsense_web/messages/zh.json
…D and generate settings hash for indexing configuration changes
Description
Motivation and Context
FIX #
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR fixes issues with the Composio Google Drive connector and makes major improvements to the inbox notification system. The backend now prevents duplicate content indexing by checking content hashes across connectors and returns both indexed and skipped counts. The notification service has been enhanced to display skipped item counts in user-friendly messages. On the frontend, the inbox has been redesigned with a dockable panel mode that can be pinned alongside content, separate data sources for mentions and status tabs with independent pagination, and improved comment navigation with automatic scrolling and highlighting. Additional UI improvements include better mobile responsiveness for audio/podcast components and table overflow handling in markdown.
⏱️ Estimated Review Time: 30-90 minutes
💡 Review Order Suggestion
surfsense_backend/app/connectors/composio_google_drive_connector.pysurfsense_backend/app/tasks/composio_indexer.pysurfsense_backend/app/routes/search_source_connectors_routes.pysurfsense_backend/app/services/notification_service.pysurfsense_backend/app/routes/notifications_routes.pysurfsense_web/lib/apis/notifications-api.service.tssurfsense_web/hooks/use-inbox.tssurfsense_web/components/layout/providers/LayoutDataProvider.tsxsurfsense_web/components/layout/ui/shell/LayoutShell.tsxsurfsense_web/components/layout/ui/sidebar/InboxSidebar.tsxsurfsense_web/components/layout/hooks/SidebarContext.tsxsurfsense_web/components/layout/hooks/index.tssurfsense_web/atoms/chat/current-thread.atom.tssurfsense_web/app/dashboard/[search_space_id]/new-chat/[[...chat_id]]/page.tsxsurfsense_web/components/assistant-ui/assistant-message.tsxsurfsense_web/components/chat-comments/comment-item/comment-item.tsxsurfsense_web/components/assistant-ui/connector-popup/config/connector-status-config.jsonsurfsense_web/components/assistant-ui/markdown-text.tsxsurfsense_web/components/assistant-ui/thread.tsxsurfsense_web/components/tool-ui/audio.tsxsurfsense_web/components/tool-ui/generate-podcast.tsxsurfsense_web/messages/en.jsonsurfsense_web/messages/zh.json