-
Notifications
You must be signed in to change notification settings - Fork 24
always use gfortran from conda on macos, update to gfortran-15 #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 13 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
41f6f7a
always use gfortran from conda on macos, update to gfortran-15
mattip c839491
remove unused submodule gfortran-install
mattip eef7a05
use tools/gfortran_install.sh
mattip d5a78e2
use tools/sha256sum.py since macos image does not have sha256sum
mattip 85f1210
reflow and fix gfortran_install.sh
mattip 69ecd81
specify MACOSX_DEPLOYMENT_TARGET=10.13 on macos-x86_64, cleanup
mattip 9379402
use gcc11 on macos-x86_64 so we can use MACOSX_DEPLOYMENT_TARGET='10.9'
mattip 18c6e04
define FF rather than mess with PATH to get gfortran
mattip 96de084
typo, increase bash verbosity
mattip 21d2cc8
typos
mattip 2580a99
improve check_gfortran
mattip ab38810
no -v in bash on macOS
mattip bcf9294
macos: always use native gfortran, re-export env variables from gfort…
mattip af083b7
revert removal of check for /usr/local/include and /usr/local/lib
mattip aebe89c
hardcode path to libgfortran.dylib
mattip f64e97b
use image's gfortran-15 on macos-arm64, remove tarball name mangling
mattip 5f0c1f2
typo
mattip 43f5e55
fixes
mayeut 5a0c095
typo
mattip 8c0ea32
do more debug
mattip 6d6c0ca
use GFORTRAN_LIBDIR like upstream
mattip 84206da
add LDFLAGS too
mattip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,3 @@ | ||
| [submodule "OpenBLAS"] | ||
| path = OpenBLAS | ||
| url = https://github.com/xianyi/OpenBLAS.git | ||
| [submodule "gfortran-install"] | ||
| path = gfortran-install | ||
| url = https://github.com/MacPython/gfortran-install.git |
Submodule gfortran-install
deleted from
3dd38d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #!/usr/bin/env python3 | ||
|
|
||
| import hashlib | ||
| import sys | ||
|
|
||
| filename = sys.argv[1] | ||
| sha256_hash = hashlib.sha256() | ||
| with open(filename,"rb") as f: | ||
| # Read and update hash string value in blocks | ||
| for byte_block in iter(lambda: f.read(32768),b""): | ||
| sha256_hash.update(byte_block) | ||
| print(sha256_hash.hexdigest()) | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was installing a cross-compiling gfortran on arm64. Maybe the source of bugs?