Skip to content

Add type check #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristjanESPERANTO merged 3 commits into from
Feb 9, 2026
Merged

Add type check #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44c8562
chore: Install `typescript` and add `test:types` command
JHWelch Feb 3, 2026
5fb8e2d
chore: Add `types` to `test` command
JHWelch Feb 4, 2026
f92e472
chore: Add typescript types to tests
JHWelch Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/automated-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,6 @@ jobs:
run: node --run lint
- name: Run Unit Tests
run: npm run test:unit
- name: Check TypeScript types
run: node --run test:types
- run: echo "🍏 This job's status is ${{ job.status }}."
1 change: 1 addition & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@
"lint": "eslint && prettier --check .",
"lint:fix": "eslint --fix && prettier . --write",
"prepare": "simple-git-hooks",
"test": "node --run test:fixtures && node --run lint && node --run golden:check && node --run schemas:check && node --run test:unit && node --run test:spelling",
"test": "node --run test:fixtures && node --run lint && node --run golden:check && node --run schemas:check && node --run test:unit && node --run test:types && node --run test:spelling",
"test:unit": "node --test scripts/**/__tests__/**/*.test.js",
"test:spelling": "cspell .",
"test:types": "tsc --noEmit",
Copy link
Contributor Author

@JHWelch JHWelch Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsc is the TypeScript Compiler. "noEmit" just does the type checks without actually "emitting" the JavaScript. "noEmit" is set to true in the tsconfig.json, so it will run in this mode by default but no reason not to be explicit here.

"leaveMenu": "echo 'Leaving menu...'"
},
"simple-git-hooks": {
Expand Down Expand Up @@ -90,6 +91,7 @@
"lint-staged": "^16.2.7",
"prettier": "^3.8.1",
"simple-git-hooks": "^2.13.1",
"typescript": "^5.9.3",
"typescript-eslint": "^8.54.0"
},
"ntl": {
Expand Down
Loading