-
Notifications
You must be signed in to change notification settings - Fork 9
Modernize MagicMirror² Website #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replace deprecated use.fontawesome.com script with cdnjs CSS link - Update all icons to FontAwesome 6 syntax (fa-solid, fa-brands) - Replace fa-diamond with fa-gem (diamond removed in FA5+) - Replace fa-simplybuilt with fa-discord for Discord link
- Replace Bootstrap with custom vanilla CSS - Remove jQuery dependency - Replace Bootstrap Grid with CSS Grid and Flexbox - Add semantic HTML5 structure (main, header, section, footer) - Maintain identical visual appearance and functionality
Implement proper scroll-triggered fadeInUp animation using Intersection Observer and vanilla CSS. The animation was previously broken due to missing JavaScript trigger - animate.css only provided the CSS but no scroll detection. - Add custom fade-in-up CSS with 30px translateY and smooth transitions - Implement Intersection Observer to trigger animation on scroll - Add staggered animation with 150ms delay between boxes - Remove animate.css dependency (67KB saved) Side effect: One less external dependency to maintain
- Replace fixed grid breakpoints with auto-fit minmax() (removed 2 media queries) - Use clamp() for fluid logo and section spacing (removed 1 media query) - Unify all breakpoints to 767px for consistency - Move media queries next to their components for better maintainability - Remove deprecated 'only screen and' syntax - Remove unnecessary !important in media queries
- CSS custom properties for light/dark themes with 0.3s transitions - Theme toggle button with localStorage → system preference → fallback logic - Extract all JavaScript to main.js ES module in <head>
- Convert fixed sizes to clamp(): h2, h3, lead, grid gap, jumbotron padding - magpi-watermark now scales with viewport - Adjust responsive breakpoint to 825px for better navbar layout"
|
Great incentive, I really like this modernization. Two things though (that are already present on the current site):
|
We removed Snyk 2020 from the projects repository: MagicMirrorOrg/MagicMirror@40886bc
|
Thanks for the feedback! It seems that my sleep problems have actually led to something productive 😅
Live preview is also updated: https://kristjanesperanto.github.io/MagicMirror-Website/
|
|
@khassel Can you explain why you are in the commit? I'm not aware that I did anything special, but you are listed as the author and I'm as the committer 🤔
I would leave it as it is if you don't mind, or should I straighten it out? |
|
Speaking of badges: I would like to get the openssf best practice badge to 100%, alas the module on bestpractices.dev is owned by @nhubbard maybe he can move it over to one of us if he sees this message? |
|
@rejas Wow I completely forgot about that! Let me see if I can move it. |
Fastest reaction I ever had from someone outside of a project :-D |
|
@rejas Can you link me your BestPractices.dev profile? I'm submitting a request to see if it can be transferred. If it can, I'll have them transfer it to you. If not, I'll delete my account and see if they can move it to you. |
it's https://www.bestpractices.dev/en/users/8747 thanks for your time and effort! |
can't explain, don't know what you did ... I did not touch your fork. But no problem, leave it as it is. The date of this strange commit is exactly the date of my last commit in this repo:
|
|
@rejas can we merge this or is the "not 100% badge" something we have to wait for? |
|
@rejas I just finished the transfer to your BestPractices account. Apparently there was a way in the UI, but I couldn't find it anywhere when I looked for it. |
Thanks, shows up as "owned" in my accoutn now. |





Live result you can checkout here: https://kristjanesperanto.github.io/MagicMirror-Website/
To compare: https://magicmirror.builders/
Major Changes
Dependencies
Dark Mode
Modern CSS & Responsive Design
clamp(60px, 12vw, 125px)Visual Enhancements
Deployment
Benefits