PCRE2 regex issue fix #371
Open
+30
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt to allow calling free, fixed pcre_offset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed uninitialized pointers when compiling mapcache with PCRE2 which was leading to segmentation faults. Compiled locally and viewed the faults occurring with the previous code by running mapcache.fcgi, and now working as expected with the fix.
For context into the issue:
When using MapCache regex dimensions on MS4W, both Apache (httpd.exe) and mapcache_seed consistently crash with an access violation in pcre2-8.dll. This reproduces on both a fresh MS4W install and an existing setup, and only occurs when regex dimensions are used. After digging into the MapCache source, it appears the PCRE2 code path for regex dimensions may be using uninitialized values when calling pcre2_compile and pcre2_match, which could explain the crashes. I was also wondering if there is an MS4W build available that uses the legacy PCRE instead of PCRE2, as a possible workaround.