Draft
Conversation
- reticle.test.js - focus leaflet container with page.focus()
- axisInferring.test.js - use EPSILON value of 0.0000001 for comparison of gcrs coordinates
- queryLink.test.js - use .click(selector, {force: true} ).
See https://playwright.dev/docs/input#forcing-the-click for why this might
be a problem, seems to only be a problem on firefox.
- featureLinks.test.js - simplify, get running on firefox
- run all tests on chromium and firefox
- layerContextMenu.test.js - does not fix underlying issue with layer context menu, but eliminates other issues.
- viewerContextMenu.test.js - does not fix underlying issue with the context menu, which is due to a playwright bug, but simplifies the code a little bit. Should run when the latter bug is fixed in playwright 1.19
Clean up context menu code that is non-functional (I think).
Upgrade playwright to ^1.17.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #631